Pull Requests

If you want to contribute to an ESLint repo, please use a GitHub pull request. This is the fastest way for us to evaluate your code and to merge it into the code base. Please don’t file an issue with snippets of code. Doing so means that we need to manually merge the changes in and update any appropriate tests. That decreases the likelihood that your code is going to get included in a timely manner. Please use pull requests.

如果你想要贡献代码到 ESLint 仓库,请使用 GitHub 发出一个合并请求(pull request)。这是我们评估你的代码并把它合并到代码库中的最快的方法。请不要提出一个包含代码片段的议题(issue)。这样做的话意味着我们需要手动地合并这些修改和更新对应的测试用例。它会降低你的代码及时地被合并的可能性。请使用合并请求(pull request)。

Getting Started

If you’d like to work on a pull request and you’ve never submitted code before, follow these steps:

如果你想要使用合并请求(pull request),但是你之前从来没有提交过代码,请遵循以下步骤:

  1. Sign our Contributor License Agreement.
  2. 签署我们的 贡献者许可协议(Contributor License Agreement)
  3. Set up a development environment.
  4. 搭建开发环境
  5. If you want to implement a breaking change or a change to the core, ensure there’s an issue that describes what you’re doing and the issue has been accepted. You can create a new issue or just indicate you’re working on an existing issue. Bug fixes, documentation changes, and other pull requests do not require an issue.
  6. 如果你想实现一个重大改变或对 ESLint 核心的改变,确保有一个 issue 描述你在做什么,而且这个 issue 已经被接受。你可以创建一个新的 issue 或只表明你正在处理一个已存在的 issue。bug 修复,文档修改,和其它合并请求(pull request)不需要有 issue。

After that, you’re ready to start working on code.


Working with Code

The process of submitting a pull request is fairly straightforward and generally follows the same pattern each time:

提交一个合并请求(pull request)的过程相当简单,一般每次都遵循相同的模式:

  1. Create a new branch
  2. 新建一个分支
  3. Make your changes
  4. 做出自己的修改
  5. Rebase onto upstream
  6. 变基(rebase) 到上游(upstream)
  7. Run the tests
  8. 运行测试
  9. Double check your submission
  10. 仔细检查你的提交
  11. Push your changes
  12. 推送你的修改
  13. Submit the pull request
  14. 提交这个合并请求(pull request)

Details about each step are found below.


Step 1: Create a new branch

The first step to sending a pull request is to create a new branch in your ESLint fork. Give the branch a descriptive name that describes what it is you’re fixing, such as:

发起一个合并请求(pull request)的第一步是,在你 fork 的 ESLint 中新建一个分支。给这个分支起一个描述性的名字用来描述你在修复什么,比如:

$ git checkout -b issue1234

You should do all of your development for the issue in this branch.


Note: Do not combine fixes for multiple issues into one branch. Use a separate branch for each issue you’re working on.


Step 2: Make your changes

Make the changes to the code and tests, following the code conventions as you go. Once you have finished, commit the changes to your branch:


$ git add -A
$ git commit

Our commit message format is as follows:


Tag: Short description (fixes #1234)

Longer description here if necessary

The first line of the commit message (the summary) must have a specific format. This format is checked by our build tools.


The Tag is one of the following:

Tag 是下列之一:

Use the labels of the issue you are working on to determine the best tag.

参考 issue 标签 选定最合适的标签.

The message summary should be a one-sentence description of the change, and it must be 72 characters in length or shorter. If the pull request addresses an issue, then the issue number should be mentioned at the end. If the commit doesn’t completely fix the issue, then use (refs #1234) instead of (fixes #1234).

描述变更的摘要信息应该是一句话,并且它不能超过72个字符。如果合并请求(pull request) 指明了一个 issue,issue 编号应该展示在最后。如果提交的变更没能彻底修复问题,请使用(refs #1234) 而不是 (fixes #1234)

Here are some good commit message summary examples:


Build: Update Travis to only test Node 0.10 (refs #734)
Fix: Semi rule incorrectly flagging extra semicolon (fixes #840)
Upgrade: Esprima to 1.2, switch to using comment attachment (fixes #730)

The commit message format is important because these messages are used to create a changelog for each release. The tag and issue number help to create more consistent and useful changelogs.


Step 3: Rebase onto upstream

Before you send the pull request, be sure to rebase onto the upstream source. This ensures your code is running on the latest available code.

在你提交合并请求(pull request)之前,一定要变基(rebase) 到上游(upstream)源头。这将确保你的代码运行在最新的可用代码之上。

git fetch upstream
git rebase upstream/master

Step 4: Run the tests

After rebasing, be sure to run all of the tests once again to make sure nothing broke:

变基(rebase) 过后, 务必再次运行测试来确保没有什么问题了。

npm test

If there are any failing tests, update your code until all tests pass.


Step 5: Double check your submission

With your code ready to go, this is a good time to double-check your submission to make sure it follows our conventions. Here are the things to check:


Step 6: Push your changes

Next, push your changes to your clone:


git push origin issue1234

If you are unable to push because some references are old, do a forced push instead:


git push -f origin issue1234

Step 7: Send the pull request

Now you’re ready to send the pull request. Go to your ESLint fork and then follow the GitHub documentation on how to send a pull request.

现在你已经准备好发合并请求(pull request)了。到你fork的 ESLint, 按照GitHub 文档 文档中如何发出一个合并请求(pull request)去做。

Following Up

Once your pull request is sent, it’s time for the team to review it. As such, please make sure to:

一旦你已发出合并请求(pull request),我们团队会检查它。因此,请确保:

  1. Monitor the status of the Travis CI build for your pull request. If it fails, please investigate why. We cannot merge pull requests that fail Travis for any reason.
  2. 监控Travis CI针对你的合并请求(pull request) 的构建状态。如果它失败了,请调查一下原因。我们不会合并因为任何原因导致 Travis 失败的合并请求(pull request)。
  3. Respond to comments left on the pull request from team members. Remember, we want to help you land your code, so please be receptive to our feedback.
  4. 回复小组成员关于这个合并请求(pull request)的评论 。记住, 我们想要帮助你使你的代码落地, 所以请接受我们的反馈。
  5. We may ask you to make changes, rebase, or squash your commits.
  6. 我们可能会要求你做出修改,变基(rebase),或是压缩(squash)你的提交。

Updating the Commit Message

If your commit message is in the incorrect format, you’ll be asked to update it. You can do so via:


$ git commit --amend

This will open up your editor so you can make changes. After that, you’ll need to do a forced push to your branch:


$ git push origin issue1234 -f

Updating the Code

If we ask you to make code changes, there’s no need to close the pull request and create a new one. Just go back to the branch on your fork and make your changes. Then, when you’re ready, you can add your changes into the branch:

如果我们要求你做出代码变更,不需要关闭这个合并请求(pull request)再去创建一个新的。只要回到你的fork 上的分支,做出你的修改。然后,当你准备好了,你可以添加你的修改到这个分支:

$ git add -A
$ git commit
$ git push origin issue1234

When updating the code, it’s usually better to add additional commits to your branch rather than amending the original commit, because reviewers can easily tell which changes were made in response to a particular review. When we merge pull requests, we will squash all the commits from your branch into a single commit on the master branch.

当更新代码时,最好在你自己的分支上添加额外的提交而不是修改原来的提交,因为评审人员很容易看出对某个特定的审查错了哪些修改。当我们合并拉取请求时,我们将把你分支的所有提交压缩成一个提交到 master 分支。


If your code is out-of-date, we might ask you to rebase. That means we want you to apply your changes on top of the latest upstream code. Make sure you have set up a development environment and then you can rebase using these commands: If your code is out-of-date, we might ask you to rebase. That means we want you to apply your changes on top of the latest upstream code. You can do so via:

如果你的代码过时了,我们也许会要求你变基(rebase)。 它意味着我们希望你把自己的变更应用到最新的上游(upstream)代码中。你可以这样做:

$ git fetch upstream
$ git rebase upstream/master

You might find that there are merge conflicts when you attempt to rebase. Please resolve the conflicts and then do a forced push to your branch:

当你试图rebase的时候,你可能会遇到合并冲突。请解决冲突(resolve the conflicts) 接着强制推送到你的分支:

$ git push origin issue1234 -f